search

colcon / colcon-argcomplete

Completion for colcon command lines using argcomplete
http://colcon.readthedocs.io
Apache License 2.0
2 stars 3 forks source link

declare hooks as data_files in setup.cfg #21

Closed dirk-thomas closed 5 years ago

dirk-thomas commented 5 years ago

The patch relies on a very recent feature added to setuptools 40.5.0 (see pypa/setuptools # 1520).

It should address #14 without introducing #19.

The renaming of the destination from share/colcon-argcomplete to share/colcon_argcomplete is unfortunately necessary since distutils on the very lowest level replaces - in keys with _ (https://github.com/python/cpython/blob/31ec52a9afedd77e36a3ddc31c4c45664b8ac410/Lib/distutils/dist.py#L414) so it is impossible to install files to a destination containing dashes. Another downside is that the files are not symlinked anymore when using develop.

dirk-thomas commented 5 years ago

In order to get a new version out and resolve #19 I will go ahead with the merge and release a new minor version.