colcon / colcon-argcomplete

Completion for colcon command lines using argcomplete
http://colcon.readthedocs.io
Apache License 2.0
2 stars 3 forks source link

Use --root specified on command line when running custom install command #23

Closed cottsay closed 5 years ago

cottsay commented 5 years ago

Instead of hand-crafting the destination path, use the --root arg passed to setup.py install by debhelper.

Fedora runs the install from the package root directory, so re-rooting the source paths isn't necessary, but the --root arg must be considered for the destination path.

dirk-thomas commented 5 years ago

In combination with #24 this fails to run ros_release_python deb3:

Install command needs to be invoked with --prefix or the data files destination must be absolute

dirk-thomas commented 5 years ago

Since this patch doesn't work for me when calling ros_release_python deb3 I created #25 which git it working for me. Therefore I will go ahead and close this ticket.