search

colcon / colcon-bundle

A colcon extension to create portable application bundles
Apache License 2.0
38 stars 24 forks source link

Only run Configure AWS Credentials on schedule #149

Closed zmichaels11 closed 4 years ago

zmichaels11 commented 4 years ago

Disable AWS configuration on tasks triggered by PRs. This will allow PRs ran from forks (that do not include AWS credentials) to run CI.

Signed-off-by: Zachary Michaels zmichaels11@gmail.com

thomas-moulard commented 4 years ago

Why do we need this? Could you add a comment, it's not obvious to me?

piraka9011 commented 4 years ago

Also you could disable to the metrics logging and not the entire credentials. That way the build logging action doesn't fail. There may be other actions using AWS we may want to leverage down the line.

zmichaels11 commented 4 years ago

Why do we need this? Could you add a comment, it's not obvious to me?

Updated issue

Also you could disable to the metrics logging and not the entire credentials. That way the build logging action doesn't fail.

Metric logging is already disabled on PRs

There may be other actions using AWS we may want to leverage down the line.

We can add that in when we need it.

piraka9011 commented 4 years ago

On the note of running PRs from forks, this now makes sense.

zmichaels11 commented 4 years ago

@thomas-moulard any more comments? If this looks good to everyone, can someone with merge privileges please merge this?