search

colcon / colcon-bundle

A colcon extension to create portable application bundles
Apache License 2.0
38 stars 24 forks source link

Respect ignore marker even if dangling symlink #164

Closed rotu closed 4 years ago

rotu commented 4 years ago

As per https://github.com/ros-infrastructure/rep/pull/256

dirk-thomas commented 4 years ago

Have you tried running the patch?

rotu commented 4 years ago

Have you tried running the patch?

I hadn't, as can be seen from CI!

rotu commented 4 years ago

This patch now works correctly and is ready for review

dirk-thomas commented 4 years ago

With the REP update merged (ros-infrastructure/rep#256) this can be merged whenever the maintainers are ready.