search

colcon / colcon-bundle

A colcon extension to create portable application bundles
Apache License 2.0
38 stars 24 forks source link

package.xml format 3 with condition doesn't work properly. #169

Closed obi-t4 closed 4 years ago

obi-t4 commented 4 years ago

colcon bundle with package.xml format 3 which contains condition like

https://github.com/KIT-MRT/mrt_cmake_modules/blob/ce7c854c48cb458cf55a238fcce4821396b695f1/package.xml#L16

does not work properly, as follows:

--- stderr: mrt_cmake_modules                      
Traceback (most recent call last):
  File "/usr/lib/python3/dist-packages/colcon_core/executor/__init__.py", line 91, in __call__
    rc = await self.task(*args, **kwargs)
  File "/usr/lib/python3/dist-packages/colcon_core/task/__init__.py", line 93, in __call__
    return await task_method(*args, **kwargs)
  File "/usr/local/lib/python3.6/dist-packages/colcon_ros_bundle/task/ros_bundle.py", line 66, in bundle
    package_name = package_name_list[0]
IndexError: list index out of range
---
obi-t4 commented 4 years ago

PR https://github.com/colcon/colcon-ros-bundle/pull/39 fixes this issue.

thomas-moulard commented 4 years ago

Thank you for the contribution, I think this should solve this ticket, feel free to re-open the issue if any additional work is needed.