search

colcon / colcon-bundle

A colcon extension to create portable application bundles
Apache License 2.0
38 stars 24 forks source link

Add integration hourly workflow #188

Closed dabonnie closed 4 years ago

dabonnie commented 4 years ago

Build and bundle a ROS1 package (navigation) using the latest released colcon-bundle (via pip).

Signed-off-by: Devin Bonnie dbbonnie@amazon.com

dabonnie commented 4 years ago
  1. Consider pinning navigation a commit ID instead of a branch so that we don't get broken because nav is broken

Good idea.

  1. Did you choose a large package on purpose? I'd suggest having a big one and a trivial one so that we can easily repro simple issues (if we can't bundle ament_cmake something is wrong, if nav can't be bundled... lots fo things go wrong)

Yes, see 4.

  1. How flaky is this? I'd suggest running that at a high frequency on a fork for a while to test this out?

That's a good question: hourly would help here.

  1. You should be using the Docker image owned by ros-tooling to avoid APT repo flakiness.

Actually, apt repo flakiness is something I wanted to test for given https://github.com/colcon/colcon-bundle/issues/178 and a patch that potentially addresses the problem.

zmichaels11 commented 4 years ago

would it make sense to have another test for apt flakiness? That way this nightly workflow is not testing for multiple variables.

dabonnie commented 4 years ago

would it make sense to have another test for apt flakiness? That way this nightly workflow is not testing for multiple variables.

Possibly, though I'd like to have a full workflow test as well.

prajakta-gokhale commented 4 years ago

Changes look good to me. I'd second Thomas' suggestion of testing on one trivial package (ament_cmake maybe?) and one big package (navigation seems fine). This way can distinguish bundle failures vs. other failures brought by big packages.

dabonnie commented 4 years ago

This is ready for re-review @thomas-moulard @prajakta-gokhale @zmichaels11.

If review passes I will open a separate PR in order to define the vcs repo file and have this PR point to that in order to merge with green CI.

dabonnie commented 4 years ago

Also currently 26 successful runs via actions on a fork (no failures) since last night run at every 30 minutes. Here's the link: https://github.com/dabonnie/colcon-bundle/actions?query=event%3Aschedule

dabonnie commented 4 years ago

Superseded by https://github.com/colcon/colcon-bundle/pull/191