search

colcon / colcon-bundle

A colcon extension to create portable application bundles
Apache License 2.0
38 stars 24 forks source link

add bash support in setup files #203

Closed anuragdmadan closed 3 years ago

anuragdmadan commented 3 years ago

Add setup.bash files to the workspace and dependency folders, which can be sourced without having to set any environment variables like BUNDLE_CURRENT_PREFIX. This will also allow users to source other setup.bash files for tab complete. The setup.bash files are created using a template.

anuragdmadan commented 3 years ago

Add setup.bash files to the workspace and dependency folders, which can be sourced without having to set any environment variables like BUNDLE_CURRENT_PREFIX

murphm8 commented 3 years ago

We will want some sort of metadata that exposes that the bash feature is implemented. This is how we create the installer metadata file: https://github.com/colcon/colcon-bundle/search?q=installer_metadata_path. Maybe we want to create a features.json or something that will contain extra feature flags used in bundles.

anuragdmadan commented 3 years ago

We will want some sort of metadata that exposes that the bash feature is implemented. This is how we create the installer metadata file: https://github.com/colcon/colcon-bundle/search?q=installer_metadata_path. Maybe we want to create a features.json or something that will contain extra feature flags used in bundles.

After speaking, it was decided that a features.json file was not required for this change. The bundle should include both setup.sh and setup.bash files and the user can decide which one needs to be sourced.