search

colcon / colcon-bundle

A colcon extension to create portable application bundles
Apache License 2.0
38 stars 24 forks source link

Prevent pip from upgrading to v21 for Xenial #210

Closed jikawa-az closed 3 years ago

jikawa-az commented 3 years ago

Force pip to stay on 20.x version.

This PR also removes a portion of the backwards compatibility integration test that relies on pip installing the latest version of colcon, which will cause the integration test to fail since it will upgrade pip to v21.

See https://pip.pypa.io/en/stable/news/#id1 release notes for v21.0, which states that support for python 3.5 is dropped.

See https://github.com/pypa/pip/issues/9515 for some more information

Similar fixes: https://github.com/ros-tooling/setup-ros-docker/pull/39 https://github.com/ros-tooling/setup-ros/pull/337

Signed-off-by: Jesse Ikawa jikawa@amazon.com

jikawa-az commented 3 years ago

Unit test failing for unrelated issue. flake8-blind-except 0.1.1 was updated to prevent blind except statements. Will open separate PR to resolve.

jikawa-az commented 3 years ago

Test section added back in, expected to pass when merged.