search

colcon / colcon-bundle

A colcon extension to create portable application bundles
Apache License 2.0
38 stars 24 forks source link

Update apt_package_blacklist.txt #219

Closed jikawa-az closed 3 years ago

jikawa-az commented 3 years ago

Update blacklist to include Gazebo 11.

We blacklist Gazebo in order to reduce the size of the bundles that are created. We run bundles in an environment where Gazebo is already installed, so Gazebo is not needed in the bundle. If someone wants to include Gazebo they can override this blacklist with the --apt-package-blacklist argument.

murphm8 commented 3 years ago

Will run tests on the bundle tomorrow and verify this is all that is needed, then approve.

murphm8 commented 3 years ago

We have confirmed that these updates to the package blacklist are what is needed to fix the issues we were seeing with Gazebo.

jikawa-az commented 3 years ago

Integration tests are failing due to unrelated issue.

jikawa-az commented 3 years ago

All checks passing now

emersonknapp commented 3 years ago

Before I hit approve - my question is "why?". Could you add this context to the PR description so that the decision trail is there for future historians?

murphm8 commented 3 years ago

We blacklist Gazebo in order to reduce the size of the bundles that are created. We run bundles in an environment where Gazebo is already installed, so Gazebo is not needed in the bundle. If someone wants to include Gazebo they can override this blacklist with the --apt-package-blacklist argument.

emersonknapp commented 3 years ago

Ok - I've edited the PR description to include the context