search

colcon / colcon-cargo

An extension for colcon-core to support Rust projects built with Cargo
http://colcon.readthedocs.io
Apache License 2.0
30 stars 20 forks source link

Update to use DependencyDescriptor #1

Closed murphm8 closed 5 years ago

murphm8 commented 5 years ago

This is an update for an upcoming change to colcon-core: colcon/colcon-core#106

dirk-thomas commented 5 years ago

The patch looks good to me. We should hold it (see https://github.com/colcon/colcon-core/pull/107#pullrequestreview-154454998).

At the end I will leave it up the maintainer of this package to merge this when ready.

murphm8 commented 5 years ago

Since this doesn't add any useful metadata this can be closed for now. If there is metadata to add in the future this package can be updated to use DependencyDescriptor and add the metadata at that time. Closing.