Closed nnmm closed 2 years ago
I tested that the example from the README still works.
@esteve There's also this PR. I'm not sure if it makes much sense for non-ROS packages to follow the https://www.ros.org/reps/rep-0122.html install space layout, but if it does, this would be a nice simplification.
@nnmm I have to look more into this, but a priori colcon-cargo
must not depend / assume the same conventions as ament_cargo
packages. colcon-cargo
is meant to be for pure cargo
packages, that don't depend on the ament
build system or ROS at all.
@esteve I changed this PR to no longer use cargo-ament-build
. Now it's just a restructuring between this package and colcon-ros-cargo.
Thanks! Unfortunately, CI seems to have a hiccup. Do you know what's missing @esteve?
@nnmm I've triggered CI again, but there seems to be a job stuck. I'll look into it later, but it doesn't seem to appear on the Github actions tab, though.
@nnmm I don't know where that job that is stuck comes from, I've submitted https://github.com/colcon/colcon-cargo/pull/23 which removes the GitHub actions to see if that test is from outside. It looks like it, there are no GitHub actions, but that job persists. I wonder if it's an organization-level webhook.
@nnmm it's really weird, seems to be coming from this old CI configuration:
but I don't understand why it's being triggered now
@nnmm CI seems to be fixed now
Cool! From renaming to main
?
This tries to make colcon-cargo a better base class for colcon-ros-cargo, so that both packages have fewer combined lines.
As a concrete benefit, colcon-cargo now supports cleaning up the build directory.
I changed the installation location for binaries to be
${prefix}/bin
, since I think that's a more standard location.