search

colcon / colcon-cargo

An extension for colcon-core to support Rust projects built with Cargo
http://colcon.readthedocs.io
Apache License 2.0
30 stars 20 forks source link

Add package identification / build tests #35

Closed luca-della-vedova closed 2 months ago

luca-della-vedova commented 2 months ago

Turns out the Windows test was failing because the executable was missing a .exe extension, addressed in https://github.com/colcon/colcon-cargo/pull/35/commits/f344affac56aa421d71eb9ed23be84ab515a23cf. I noticed that codecov was added but it seems not to run for this PR, I tried closing and reopening but it doesn't seem to help, I can create a new PR if needed

codecov-commenter commented 2 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 46.98%. Comparing base (718630a) to head (f344aff).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #35 +/- ## ========================================== + Coverage 0.00% 46.98% +46.98% ========================================== Files 6 6 Lines 166 166 Branches 0 24 +24 ========================================== + Hits 0 78 +78 + Misses 166 74 -92 - Partials 0 14 +14 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

cottsay commented 2 months ago

I noticed that codecov was added but it seems not to run for this PR, I tried closing and reopening but it doesn't seem to help, I can create a new PR if needed

This was my fault, and I addressed it in colcon/ci#32. Coverage uploads from forks weren't working.

Coverage +46.98%

:tada: Nice work!