search

colcon / colcon-cargo

An extension for colcon-core to support Rust projects built with Cargo
http://colcon.readthedocs.io
Apache License 2.0
30 stars 20 forks source link

Replace deprecated calls to check_call() with run() #6

Closed ThijsRay closed 4 years ago

ThijsRay commented 4 years ago

When using colcon build or colcon test on a Cargo project, the user gets the following message.

/usr/local/lib/python3.6/dist-packages/colcon_cargo-0.1.1-py3.6.egg/colcon_cargo/task/cargo/test.py:54: UserWarning: colcon_core.task.check_call() has been deprecated, use colcon_core.task.run() instead

This pull request aims to change this call from check_call() to run() in order to suppress this message. Besides that, the version number is increase from v0.1.1 to v0.1.2.

gbiggs commented 4 years ago

check_call() has been changed to just call through to the new run() method, so this change should not have any noticeable impact other than not showing the deprecation notice.

lelongg commented 4 years ago

thanks for the update