search

colcon / colcon-clean

A colcon extension to clean package workspaces
http://colcon.readthedocs.io
Apache License 2.0
46 stars 4 forks source link

Register colcon-clean extension points #19

Closed cottsay closed 2 years ago

cottsay commented 2 years ago

Registering the extension points in this way will make them visible when running colcon extesion-points.

ruffsl commented 2 years ago

@cottsay Could you check if something like this is needed for colcon-cache? I'm unsure if I've missed registering a extension point there as well.

cottsay commented 2 years ago

Could you check if something like this is needed for colcon-cache?

The biggest value-add to registering like this is to improve debugging and to better advertise the extension point so that it can be discovered. IMO, the sub-verb extension points should maybe not be advertised like this, but I'm siding with the precedent laid forth by colcon-mixin. If it's an extension point that you can feasibly see someone creating an extension for in a separate package, then I think there's value in registering it like this.

Looks like colcon-cache defines a subverb extension point as well as 2 others that look like great candidates for registering.