colcon / colcon-clean

A colcon extension to clean package workspaces
http://colcon.readthedocs.io
Apache License 2.0
46 stars 4 forks source link

review prototype #4

Closed ruffsl closed 3 years ago

ruffsl commented 3 years ago

A placeholder PR to review the current extension prototype of colcon-cache.

You can basically use the clean subverbs to delete base folders per workspace or per package in workspace. It makes use of the same base args as other commands use to set the base paths, and provides a confirmation prompt that can be automatically accepted before touching any paths. By default it will try and clean all base folders that it has a base_handler extension for: i.e. currently '[build, install, log, test_result]', unless the base selection arg is used to override with a user provided list. The packages subverb is largely the same as the workspace subverb, except it cleans on a per package basis using package selection args, and ignores dealing with the log base path.

Preliminary feedback on extension architecture or suggestions for unit/system testing are welcome.