search

colcon / colcon-clean

A colcon extension to clean package workspaces
http://colcon.readthedocs.io
Apache License 2.0
46 stars 4 forks source link

Relax mandatory need for relative base paths #41

Closed ruffsl closed 9 months ago

ruffsl commented 1 year ago

by using os.path.relpath() instead of path.relative_to(), allowing for absolute paths that are not sub paths to CWD.

Fixes https://github.com/colcon/colcon-clean/issues/37

codecov-commenter commented 1 year ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (c7ff24c) 100.00% compared to head (f35cef8) 100.00%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #41 +/- ## ========================================= Coverage 100.00% 100.00% ========================================= Files 11 11 Lines 268 269 +1 Branches 40 41 +1 ========================================= + Hits 268 269 +1 ``` | [Files](https://app.codecov.io/gh/colcon/colcon-clean/pull/41?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=colcon) | Coverage Δ | | |---|---|---| | [colcon\_clean/subverb/\_\_init\_\_.py](https://app.codecov.io/gh/colcon/colcon-clean/pull/41?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=colcon#diff-Y29sY29uX2NsZWFuL3N1YnZlcmIvX19pbml0X18ucHk=) | `100.00% <100.00%> (ø)` | |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

Benjamin-Tan commented 11 months ago

@cottsay do you have any comments on this PR?