colcon / colcon-cmake

Extension for colcon to support CMake packages
http://colcon.readthedocs.io
Apache License 2.0
16 stars 25 forks source link

xunit.xml test results not found in --test-result-base #105

Open Aposhian opened 3 years ago

Aposhian commented 3 years ago

79 copies CTest Test.xml files over to the directory specified by --test-result-base, but not the *.xunit.xml result files. Since I am looking for my xunit "test results", the following documentation is misleading to me:

The base path for all test results. The default value is the --build-base argument. Each package uses a subdirectory in that base path as its package specific test result directory.

https://colcon.readthedocs.io/en/released/reference/verb/test.html

It seems like *.xunit.xml files should be copied over as well, or the documentation could be clarified.

hidmic commented 2 years ago

Perhaps documentation promises too much. colcon through colcon-cmake supports CTest. It doesn't (and cannot) account for whatever output those tests may generate. There isn't even a convention (e.g. a CMake variable) to be leveraged. So I agree documentation should warn that the set of test results may vary with each colcon extension supporting the test verb.

CC @dirk-thomas for feedback.

dirk-thomas commented 2 years ago

colcon can only handle what it knows about. So rephrasing the documentation to make this explicit is probably the best approach.

hidmic commented 2 years ago

@Aposhian would you contribute a patch to docs?

Aposhian commented 2 years ago

Yes I can do that.