search

colcon / colcon-cmake

Extension for colcon to support CMake packages
http://colcon.readthedocs.io
Apache License 2.0
16 stars 25 forks source link

PRs failing on flake8 `DeprecationWarning: SelectableGroups` #108

Closed KazNX closed 2 years ago

KazNX commented 2 years ago

Hi,

I'm getting the following deprecation warning from flake8 which is failing some PRs I've put up

DeprecationWarning: SelectableGroups dict interface is deprecated. Use select. [snip] FAILED test/test_flake8.py::test_flake8 - DeprecationWarning: SelectableGroup...

As far as I can tell, this is not to do with my changes. I'd infer that something has changed in flake8 and the flake8 validation script needs to be updated.

I've successfully run the test_flake8 script locally with Python 3.8 and flake8 3.9.2.

Please advise. Thanks.

dirk-thomas commented 2 years ago

The referenced PR fixed the unrelated CI failures. Please rebase your PR to hopefully pass CI.

KazNX commented 2 years ago

Thanks. Seems to have done the trick. I've rebased the PRs and they are now passing the CI checks.