Args options for CMake `--build` and `--install`

colcon / colcon-cmake

Extension for colcon to support CMake packages

http://colcon.readthedocs.io

Apache License 2.0

16 stars 25 forks source link

Args options for CMake `--build` and `--install` #110

Open KazNX opened 2 years ago

KazNX commented 2 years ago

Add --cmake-build-args to support passing arguments through to cmake --build Add --cmake-install-args to support passing arguments through to cmake --install

This PR supercedes https://github.com/colcon/colcon-cmake/pull/107 . See that PR for discussion history.

cottsay commented 2 years ago

This LGTM. cottsay ?

On my list for this week.

hidmic commented 2 years ago

@cottsay ping.

hidmic commented 2 years ago

@KazNX will you pick this up again in the near future? If not, I'll try and push this over the line. It'll benefit folks using colcon with ninja (like myself).

KazNX commented 2 years ago

@hidmic Been busy. I've posted some questions for @cottsay regarding how to go about implementing what he proposes.

KazNX commented 1 year ago

@ruffsl Follow up from IROS. I'm waiting on feedback on how to address the MAKEFLAGS questions. Personally, I'm not a fan of pulling from environment variables which are specific to a particular CMake generator - e.g., MAKEFLAGS is not relevant to MSBuild.