colcon / colcon-cmake

Extension for colcon to support CMake packages
http://colcon.readthedocs.io
Apache License 2.0
16 stars 25 forks source link

colcon more restrictive on project names than CMake #125

Open Aposhian opened 1 year ago

Aposhian commented 1 year ago

Is there a reason why colcon will only accept project names that have alphanumerics, dashes and underscores?

https://github.com/colcon/colcon-cmake/blob/master/colcon_cmake/package_identification/cmake.py#L165

I agree that in an ideal world, that would be a nice naming convention, but in reality some projects do not conform to that because CMake doesn't make them. Examples:

Can we make the regex more lax, without breaking other things in colcon? The fallback behavior to the directory name is good, but it shouldn't happen when there is a valid CMake project name specified.