search

colcon / colcon-cmake

Extension for colcon to support CMake packages
http://colcon.readthedocs.io
Apache License 2.0
16 stars 25 forks source link

Use packaging.version in place of pkg_resources.parse_version #133

Closed cottsay closed 9 months ago

cottsay commented 10 months ago

This is an API breaking change, but I don't really see a good way to avoid it.

@KazNX FYI

cottsay commented 9 months ago

The API break mentioned here is due to the return type changing in response right?

Affirm.

How much duck typing overlap is there between the old and new type?

Probably a lot. I think maybe pkg_resources was just using a bundled version of packaging.

This is a break and so worthy of a major bump but how much impact do we anticipate downstream?

I anticipate no breakage. This function was introduced in #57 to support a specific feature and isn't used in any supported colcon packages outside of colcon-cmake itself. We're pre-1.0 here, and colcon-core should lead the 1.0 drive, so I think a minor bump will be sufficient.