colcon / colcon-cmake

Extension for colcon to support CMake packages
http://colcon.readthedocs.io
Apache License 2.0
16 stars 25 forks source link

expose API to extract find_package-like CMake function calls #4

Closed mikaelarguedas closed 6 years ago

mikaelarguedas commented 6 years ago

this allows for reuse in this package and for extension wanting to leverage that feature (e.g. https://github.com/eProsima/Fast-RTPS/pull/207#issuecomment-383248609)

mikaelarguedas commented 6 years ago

spell checker was not happy with regex. It may be worth adding it to a whitelist (this one?) if we think that's something we'll use "regular"ly

dirk-thomas commented 6 years ago

After talking offline I pushed a modified patch which keeps the pattern, the regex evaluation and the extraction of the desired capture groups within a single function to avoid exposing too much information.

mikaelarguedas commented 6 years ago

lgtm, We could reuse that regex to find the project name. But as discussed offline we can do that separately.

Travis is unhappy though, looks like an install fluke