colcon / colcon-cmake

Extension for colcon to support CMake packages
http://colcon.readthedocs.io
Apache License 2.0
16 stars 25 forks source link

Provide options for generator override on Windows. #53

Closed seanyen closed 4 years ago

seanyen commented 4 years ago

Beginning from Visual Studio 2017 15.4, the toolchain comes with CMake and Ninja built-in support. It would be great to see Windows developers can have the free choice on what generator to use. This pull request is to unblock the hard-coded decision in colcon-cmake and allow developers to pass --cmake-args -G Ninja to specify the generator by their choices.

dirk-thomas commented 4 years ago

Thanks for the patch.