search

colcon / colcon-cmake

Extension for colcon to support CMake packages
http://colcon.readthedocs.io
Apache License 2.0
16 stars 25 forks source link

Expose '--ctest-pytest-with-coverage' option #68

Closed christophebedard closed 4 years ago

christophebedard commented 4 years ago

This exposes a --ctest-pytest-with-coverage option for 'cmake' packages. The intent is to use this to generate coverage information for pytest tests with CMake.

Related to https://github.com/ament/ament_cmake/pull/226

dirk-thomas commented 4 years ago

Since this option is not applicable to all CMake packages but only ROS/ament CMake packages this should be added to colcon-ros instead.

Before updating this I would recommend to wait for the feedback on ament/ament_cmake#226 to settle. Maybe the best way would be to set the to-be-created CMake option if the existing argument --pytest-with-coverage is set?

christophebedard commented 4 years ago

Since this option is not applicable to all CMake packages but only ROS/ament CMake packages this should be added to colcon-ros instead.

Makes sense!

Before updating this I would recommend to wait for the feedback on ament/ament_cmake#226 to settle.

Will do.

Maybe the best way would be to set the to-be-created CMake option if the existing argument --pytest-with-coverage is set?

Correct me if I'm wrong, but what you're suggesting over in https://github.com/ament/ament_cmake/pull/226#issuecomment-604219217 is to use a CMake option(...), which needs to be set at build time, while that existing --pytest-with-coverage flag is used when testing (colcon test).

If the above is correct, yes, a similar flag for colcon build makes sense.

christophebedard commented 4 years ago

I'm going to close this in favour of https://github.com/colcon/colcon-ros/pull/101. Feel free to keep the discussion here or just move it there.