search

colcon / colcon-cmake

Extension for colcon to support CMake packages
http://colcon.readthedocs.io
Apache License 2.0
16 stars 26 forks source link

Handle cmake '-G<generator>' syntax #85

Closed KazNX closed 4 years ago

KazNX commented 4 years ago

CMake supports generators specified using '-G ' (2 arguments) or as '-G' (1 argument). This change adds colcon support for the latter, one argument syntax.

dirk-thomas commented 4 years ago

Thanks for the patch. I refactored the logic in d82515d5ecaf9dad8466ca15de301ef2b7cf25af to avoid the extra nesting and avoid touching the existing line.

Please use the GitHub specific keyword "Fixes #86" in the description in the future to automatically close the referenced issue.

KazNX commented 4 years ago

Noted. I created these in the opposite order :)

KazNX commented 4 years ago

On the logic front, I was avoiding specifying the string -G twice