Closed garyservin closed 3 years ago
Thanks for the patch. This fixes a regression introduced by #89.
@dirk-thomas I see the new version including this has been released, but I don't see it yet on the ros2 repo http://repo.ros2.org/ubuntu/main/pool/main/p/python3-colcon-cmake/ . When can we expect it to be available?
Thanks!
@garyservin The new Debian package has only yesterday been imported into the ROS bootstrap repo (after the workflow for making Python releases has been changed, see colcon/colcon.readthedocs.org#75), from there into main ROS repos (http://build.ros2.org/job/import_upstream/290/), and from there to the main mirror at OSU (http://build.ros2.org/job/upload_main/105/). The new version of colcon-cmake
is listed now in the directory you referenced.
awesome, thanks!
After https://github.com/colcon/colcon-cmake/commit/c9a13a63d2a3cb0f58a165ae5828c9d433fa187f was merged, running
colcon test
with--test-result-base
fails with:This is because paths are being passed as pathlib objects instead of strings, this PR fixes the issue. cc: @paulbovbel