colcon / colcon-cmake

Extension for colcon to support CMake packages
http://colcon.readthedocs.io
Apache License 2.0
16 stars 25 forks source link

Use command environment for determining MAKE args #98

Closed cottsay closed 3 years ago

cottsay commented 3 years ago

Instead of grabbing the colcon process environment variables to determine what MAKEFLAGS will be when the process is invoked, grab the actual environment variables under which MAKE will be invoked.

cottsay commented 3 years ago

can you please briefly describe for which use case you needed this change

I'm experimenting with an extension which will augment the behavior of make by changing the MAKEFLAGS. I'm not sure yet whether this change is actually required for that effort, but is an improvement none the less, because it performs the check based on what variables will actually be passed to make, and not what the variables were when colcon was invoked.