search

colcon / colcon-core

Command line tool to build sets of software packages
http://colcon.readthedocs.io
Apache License 2.0
103 stars 46 forks source link

Add sysconfig scheme workaround for osx_framework_library #514

Closed cottsay closed 2 years ago

cottsay commented 2 years ago

The Homebrew folks took a similar approach to Debian's patch, but it's worse because their purelib completely disregards {prefix} entirely, meaning that colcon is attempting to install stuff into Homebrew's prefix path.

See https://github.com/Homebrew/homebrew-core/blob/2f008323193f636d32c4a970caa9e8b528c6c430/Formula/python%403.10.rb#L62-L68

codecov[bot] commented 2 years ago

Codecov Report

Merging #514 (821e0e6) into master (8b59ff6) will not change coverage. The diff coverage is 0.00%.

@@           Coverage Diff           @@
##           master     #514   +/-   ##
=======================================
  Coverage   81.70%   81.70%           
=======================================
  Files          60       60           
  Lines        3564     3564           
  Branches      684      684           
=======================================
  Hits         2912     2912           
  Misses        601      601           
  Partials       51       51
Impacted Files Coverage Δ
colcon_core/python_install_path.py 75.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 8b59ff6...821e0e6. Read the comment docs.