colcon / colcon-core

Command line tool to build sets of software packages
http://colcon.readthedocs.io
Apache License 2.0
103 stars 46 forks source link

Remove setup.py link after successful _undo_develop #578

Closed cottsay closed 1 year ago

cottsay commented 1 year ago

This function reverts a previous setuptools 'develop' operation, but doesn't actually clean up the artifacts under the build tree that it used to determine that 'develop' was previously used. The result is that after performing a build with --symlink-install, all subsequent builds of that package without --symlink-install will run the commands to "undo" the develop operation even if there is nothing to undo.

This should provide a small performance improvement under those specific circumstances.

codecov[bot] commented 1 year ago

Codecov Report

Patch coverage has no change and project coverage change: -0.05% :warning:

Comparison is base (c8995e3) 81.93% compared to head (22348e9) 81.89%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #578 +/- ## ========================================== - Coverage 81.93% 81.89% -0.05% ========================================== Files 65 65 Lines 3753 3755 +2 Branches 724 725 +1 ========================================== Hits 3075 3075 - Misses 622 624 +2 Partials 56 56 ``` | [Files Changed](https://app.codecov.io/gh/colcon/colcon-core/pull/578?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=colcon) | Coverage Δ | | |---|---|---| | [colcon\_core/task/python/build.py](https://app.codecov.io/gh/colcon/colcon-core/pull/578?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=colcon#diff-Y29sY29uX2NvcmUvdGFzay9weXRob24vYnVpbGQucHk=) | `40.68% <0.00%> (-0.41%)` | :arrow_down: |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.