colcon / colcon-core

Command line tool to build sets of software packages
http://colcon.readthedocs.io
Apache License 2.0
99 stars 44 forks source link

Use a normalized package name in Python build test #606

Closed cottsay closed 6 months ago

cottsay commented 6 months ago

It appears that newer setuptools versions are no longer normalizing the package name. Rather than update the name that we're looking for, we should just use a normalized name to begin with so that the test works with both old and newer setuptools versions.

codecov[bot] commented 6 months ago

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (8836d3a) 83.32% compared to head (434f436) 83.32%. Report is 1 commits behind head on master.

Files Patch % Lines
colcon_core/__init__.py 0.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #606 +/- ## ======================================= Coverage 83.32% 83.32% ======================================= Files 65 65 Lines 3760 3760 Branches 725 725 ======================================= Hits 3133 3133 Misses 551 551 Partials 76 76 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.