colcon / colcon-core

Command line tool to build sets of software packages
http://colcon.readthedocs.io
Apache License 2.0
103 stars 46 forks source link

Update setuptools deprecations AGAIN #607

Closed cottsay closed 8 months ago

cottsay commented 8 months ago

It seems that setuptools has made changes which require us to update our deprecation warning suppression. I think it actually changed twice: once that regressed the stacklevel for the warning, and another time which changed the message entirely.

TIL that suppressing setuptools warnings is akin to whack-a-mole.

In addition to CI, I tested this with setuptools 69.0.3 and 67.7.2.

codecov[bot] commented 8 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (500dec0) 83.30% compared to head (2759ce5) 83.30%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #607 +/- ## ======================================= Coverage 83.30% 83.30% ======================================= Files 65 65 Lines 3762 3762 Branches 727 727 ======================================= Hits 3134 3134 Misses 552 552 Partials 76 76 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.