search

colcon / colcon-core

Command line tool to build sets of software packages
http://colcon.readthedocs.io
Apache License 2.0
99 stars 44 forks source link

Refactor python build test to improve coverage #612

Closed cottsay closed 5 months ago

cottsay commented 5 months ago

Switching to a parametrized approach also significantly reduces duplicated code in the test.

codecov[bot] commented 5 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (6529b6b) 83.24% compared to head (c5a3d1a) 83.66%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #612 +/- ## ========================================== + Coverage 83.24% 83.66% +0.42% ========================================== Files 65 65 Lines 3765 3765 Branches 728 728 ========================================== + Hits 3134 3150 +16 + Misses 555 541 -14 + Partials 76 74 -2 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

cottsay commented 5 months ago

Thanks for the review. Even though the code coverage didn't improve very much with this change, I believe it covers some critical use cases that were previously gaps in our testing.