colcon / colcon-core

Command line tool to build sets of software packages
http://colcon.readthedocs.io
Apache License 2.0
103 stars 46 forks source link

Re-work extension point test mocking #622

Closed cottsay closed 6 months ago

cottsay commented 7 months ago

The existing mocks are fragile and don't reliably work in all cases.

This approach uses an actual Distribution instance so that we don't need to modify it to reflect upstream changes to the interface.

codecov[bot] commented 7 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (ee44262) 83.37% compared to head (df3deec) 83.37%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #622 +/- ## ======================================= Coverage 83.37% 83.37% ======================================= Files 66 66 Lines 3789 3789 Branches 737 737 ======================================= Hits 3159 3159 Misses 556 556 Partials 74 74 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.