colcon / colcon-lcov-result

A colcon extension for collecting lcov output
http://colcon.readthedocs.io
Apache License 2.0
7 stars 5 forks source link

Use package realpath instead of path #11

Closed jpsamper2009 closed 4 years ago

jpsamper2009 commented 4 years ago

How to test

  1. Clone this repository and checkout this branch
  2. Install colcon and extensions in a virtual environment (to prevent messing up your current environment)
    $  cd ~
    $ python3 -m venv colcon-venv
    $ source colcon-venv/bin/activate
    $ pip3 install colcon-common-extensions
    $ cd /path/to/colcon-lcov-result
    $ pip3 install .  # Installs colcon-lcov-result
  3. Follow the workflow in the README.rst to generate results (https://github.com/colcon/colcon-lcov-result/tree/master#usage)

References

jpsamper2009 commented 4 years ago

@piraka9011 @ivanpauno

I've pushed a branch with the suggested changes from #10. I've done my own checks, but please test and make sure that the fix works for you. If it does, I'll create release 0.2.3. If not, we can iterate.

piraka9011 commented 4 years ago

Thanks for the fix! This is probably another PR but could we add tests to catch breakage from any upstream changes? Something similar to what colcon/colcon-sanitizer-reports or using ros-tooling/action-ros-ci?

piraka9011 commented 4 years ago

@jpsamper2009 friendly ping!

j-rivero commented 4 years ago

I can confirm that this PR solves the problem for the use case detailed in the description when running colcon lcov-result. Thanks for the work guys.

jpsamper2009 commented 4 years ago

Thanks for the fix! This is probably another PR but could we add tests to catch breakage from any upstream changes? @piraka9011 Something similar to what colcon/colcon-sanitizer-reports or using ros-tooling/action-ros-ci?

Definitely! Do you mind creating an issue?

jpsamper2009 commented 4 years ago

@j-rivero @piraka9011 @ivanpauno I'm released v0.3.0. Take it for a spin and let me know if it works. I haven't released this in over a year, so it's possible I didn't do something right :), so just ping me if that's the case