Closed jpsamper2009 closed 4 years ago
@piraka9011 @ivanpauno
I've pushed a branch with the suggested changes from #10. I've done my own checks, but please test and make sure that the fix works for you. If it does, I'll create release 0.2.3. If not, we can iterate.
Thanks for the fix! This is probably another PR but could we add tests to catch breakage from any upstream changes? Something similar to what colcon/colcon-sanitizer-reports or using ros-tooling/action-ros-ci?
@jpsamper2009 friendly ping!
I can confirm that this PR solves the problem for the use case detailed in the description when running colcon lcov-result
. Thanks for the work guys.
Thanks for the fix! This is probably another PR but could we add tests to catch breakage from any upstream changes? @piraka9011 Something similar to what colcon/colcon-sanitizer-reports or using ros-tooling/action-ros-ci?
Definitely! Do you mind creating an issue?
@j-rivero @piraka9011 @ivanpauno I'm released v0.3.0. Take it for a spin and let me know if it works. I haven't released this in over a year, so it's possible I didn't do something right :), so just ping me if that's the case
How to test
colcon
and extensions in a virtual environment (to prevent messing up your current environment)References