colcon / colcon-lcov-result

A colcon extension for collecting lcov output
http://colcon.readthedocs.io
Apache License 2.0
7 stars 5 forks source link

Add support for ros.catkin packages #22

Closed matthew-reynolds closed 3 years ago

matthew-reynolds commented 3 years ago

Fixes #18.

Tested locally with a Noetic ws (ros_control & ros_controllers). Works as expected.

As a sanity check, I created a quick Foxy ws with the same-ish packages (ros2_control & ros2_controllers), and they match up nicely.

christophebedard commented 3 years ago

I'll create a new release soon.

christophebedard commented 3 years ago

Seems like I can't do any of the two releases (PyPI/deb). I'll take a closer look in a day or two.

christophebedard commented 3 years ago

PyPI release: https://pypi.org/project/colcon-lcov-result/

I also opened a PR to update ros-tooling/setup-ros to use 0.5.0 :grin: https://github.com/ros-tooling/setup-ros/pull/318

dirk-thomas commented 3 years ago

In case you also want to make a Debian package release: https://colcon.readthedocs.io/en/released/developer/release.html

christophebedard commented 3 years ago

In case you also want to make a Debian package release: https://colcon.readthedocs.io/en/released/developer/release.html

I tried, but packagecloud.io seems to want me to pay to keep using my account. Uploads fail with HTTP 402. I assumed I could contribute without a paid plan. I've sent them an email asking about it so we'll see.

dirk-thomas commented 3 years ago

I've sent them an email asking about it so we'll see.

Any update on this? The idea was that anyone can be added as a contributor to upload artifacts without the need to pay for the account. As a matter of fact even I don't have a paid account with them but got a free account for this open source project.

christophebedard commented 3 years ago

Any update on this?

Never got a reply, which is unfortunate, but I "fixed" it. I just uploaded 0.5.0. I'm about to create a PR on ros-infrastructure/reprepro-updater now.