colcon / colcon-mixin

Extension for colcon to read CLI mixins from files
http://colcon.readthedocs.io
Apache License 2.0
2 stars 7 forks source link

Allow mixins to also specify boolean arguments #12

Closed emersonknapp closed 5 years ago

emersonknapp commented 5 years ago

Tested using following mixin. Allows for specifying other bool args like --cmake-clean-first etc

---
build:
  libcxx:
    merge-install: True
    cmake-args:
    - "-DCMAKE_C_COMPILER=clang-6.0"
    - "-DCMAKE_CXX_COMPILER=clang++-6.0"
    build-base: "clangbuild"
    install-base: "clanginstall"
thomas-moulard commented 5 years ago

LGTM!

emersonknapp commented 5 years ago

@dirk-thomas can we merge this? I am finding it very useful for my local mixins in my workflows, e.g. to specify merge-install

dirk-thomas commented 5 years ago

Thanks for the patch.