colcon / colcon-mixin

Extension for colcon to read CLI mixins from files
http://colcon.readthedocs.io
Apache License 2.0
2 stars 7 forks source link

use argument defaults from colcon-core, fix package name completion #19

Closed dirk-thomas closed 4 years ago

dirk-thomas commented 4 years ago

Requires colcon/colcon-core#332. The minimum dependency needs to be bumped once that patch has been released in colcon-core.

Use argument default wrapping added in colcon/colcon-core#288 rather than the custom solution from this package.

This resolves a regression introduced in colcon/colcon-recursive-crawl#17 which broke the completion of package names. The different approaches to wrap / unwrap did interfere with each other since the value is not yet unwrapped when the completion logic tries to discover the package names. The approach from colcon-core ensures that the default value stays usable.