colcon / colcon-parallel-executor

Extension for colcon to process packages in parallel
http://colcon.readthedocs.io
Apache License 2.0
2 stars 4 forks source link

Refine semantics of --parallel-workers argument #29

Closed cottsay closed 1 year ago

cottsay commented 2 years ago

Two changes:

  1. Introduce special behavior when zero is specified, which will mean that there is no limit to the number of workers and that all unblocked jobs should be executed in parallel.
  2. Check for negative numbers and raise a proper usage error when specified.
nuclearsandwich commented 2 years ago

Are there any hard limits we need to be aware of like a max number of threads / futures in the Python runtime or will the runtime manage those for us?

cottsay commented 2 years ago

Are there any hard limits we need to be aware of like a max number of threads / futures in the Python runtime or will the runtime manage those for us?

I have no clue, but I can't imagine we'd ever hit it, given that we'd need that number of simultaneously executable jobs. My motivation for this change is to provide a mechanism to actually disable this limiter to make room for other job restriction approaches, like a jobserver.