colcon / colcon-parallel-executor

Extension for colcon to process packages in parallel
http://colcon.readthedocs.io
Apache License 2.0
2 stars 4 forks source link

fix handling of SIGINT in combination with continue-on-error #9

Closed dirk-thomas closed 6 years ago

dirk-thomas commented 6 years ago

Fixes colcon/colcon-core#104.

Without this patch SIGINT was treated as any "normal" error code. So without --abort-on=error the parallel executor would continue.

The patch makes sure to abort when the return code is SIGINT. It does that independently of any previously finished job with a non-zero return code as well as cases where the SIGINT isn't signaled by a signal.SIGINT but using a KeyboardInterrupt or SIGINT_RESULT.