search

colcon / colcon-python-setup-py

Extension for colcon to support Python packages with the metadata in the setup.py file
http://colcon.readthedocs.io
Apache License 2.0
2 stars 7 forks source link

If a project has a setup.cfg file, colcon ignores the setup.py file completely #17

Closed rotu closed 5 years ago

rotu commented 5 years ago

When creating a setup.py file, setup.cfg can be used to specify some data in a declarative manner. But the logic in RosPackageIdentification.identify ignores the setup.py file if a setup.cfg file is specified.

This came up in an ugly way for my project which defines data_files in setup.py but defines some other package data in the setup.cfg file. When colcon attempts to install the project with --symlink-install option, it completely omits the package data, since it only looks at the cfg file.

rotu commented 5 years ago

oops. the responsible code lives in colcon-ros. moving this issue to https://github.com/colcon/colcon-ros/issues/65