search

colcon / colcon-python-setup-py

Extension for colcon to support Python packages with the metadata in the setup.py file
http://colcon.readthedocs.io
Apache License 2.0
2 stars 7 forks source link

Make subprocess calls faster by not using ProcessPoolExecutor #25

Closed rotu closed 4 years ago

rotu commented 5 years ago

Follow up to #22, #24

Adds and uses a new function wrapper out_of_process which wraps a python function into a subprocess.

Address some performance concerns by using multiprocessing.Process instead of multiprocessing.Pool when we’re not reusing the same pool.

dirk-thomas commented 5 years ago

Please spend the time to write a description what this PR contains, and if applicable what other PRs it replaces. Also please address the CI failure.

rotu commented 5 years ago

Done.

dirk-thomas commented 5 years ago

Also please address the CI failure.

Still failing CI.

rotu commented 5 years ago

d'oh!

dirk-thomas commented 4 years ago

Parts of this change have in the meantime landed, e.g. the usage of distutils.core.run_setup() in #30.

@rotu Would you like to revisit other parts of this change and rebase them or should this be closed?

dirk-thomas commented 4 years ago

Would you like to revisit other parts of this change and rebase them or should this be closed?

I will go ahead and close the ticket for now. Please feel free to rebase / update the branch and it can be reopened.