search

colcon / colcon-ros

Extension for colcon to support ROS packages
http://colcon.readthedocs.io
Apache License 2.0
13 stars 26 forks source link

Fix wrong default for --catkin-skip-building-tests #111

Closed agutenkunst closed 4 years ago

agutenkunst commented 4 years ago

Closes https://github.com/colcon/colcon-ros/issues/110

dirk-thomas commented 4 years ago

This changes doesn't look right.

Please see my detailed comment on the original issue (https://github.com/colcon/colcon-ros/issues/110#issuecomment-654967516) about not being able to reproduce the problem.

agutenkunst commented 4 years ago

I am sorry I misinterpreted to action from argparse. If the argument is ommited aka the default value the negation of action is true. Closing.