search

colcon / colcon-ros

Extension for colcon to support ROS packages
http://colcon.readthedocs.io
Apache License 2.0
13 stars 26 forks source link

Add AmentInstalledPackageFinder for override warning #129

Closed sloretz closed 2 years ago

sloretz commented 2 years ago

Part of https://github.com/ros2/ros2/issues/1150

Requires colcon/colcon-core#449

This adds a FindInstalledPackagesExtensionPoint extension that uses the ament_index to determine what packages are installed. It allows warning if any packages in /opt/ros/<rosdistro> are being overridden in a colcon workspace.

sloretz commented 2 years ago

CI failed because of https://github.com/python/importlib_metadata/issues/298 - which also means the flake8 linter didn't get a chance to run. I can double check it locally.

sloretz commented 2 years ago

Note when this is merged and released, it should include a version dependency on the released version of colcon-core with colcon/colcon-core#449 https://github.com/colcon/colcon-core/pull/449#issuecomment-983506230

sloretz commented 2 years ago

Merged with master to run new actions based CI

sloretz commented 2 years ago

CI LGTM, and approved, so merging