search

colcon / colcon-ros

Extension for colcon to support ROS packages
http://colcon.readthedocs.io
Apache License 2.0
13 stars 26 forks source link

Add logic for excluding group workaround dependencies #155

Closed cottsay closed 3 months ago

cottsay commented 4 months ago

See ros-infrastructure/catkin_pkg#369

cottsay commented 4 months ago

colcon-ros already supports group dependencies (within the workspace, which is the only context in which it supports any dependencies) and so it should already not need this workaround

Correct.

cottsay commented 4 months ago

We're going to need to block this change for now. Turns out that we actually have some messed up group unrolling in ROS 2 and this change exposes those bugs.

Who knew that manually curating a list of group members in downstream packages would be error prone?

I'll probably end up enabling this eventually as a feature flag once that change lands.

cottsay commented 4 months ago

We're going to need to block this change for now.

After thinking about it, we actually don't. This doesn't change behavior in any manifests which aren't annotated with the workaround skipping logic, so a long as we fix the group unrolling at the same time, we'll never regress anything.