colcon / colcon-ros

Extension for colcon to support ROS packages
http://colcon.readthedocs.io
Apache License 2.0
13 stars 26 forks source link

Dependency `condition` attribute for ament_python #156

Closed christophfroehlich closed 3 months ago

christophfroehlich commented 3 months ago

As defined in REP-149 there should be the condition attribute for the dependencies, independent of the built_type

Something like

<test_depend condition="1 == 2">ament_cmake_flake8</test_depend>

works perfectly fine in an ament_cmake package, but is not considered in an ament_python package.

Am I doing something wrong? Or is this intentional, or just not implemented?

christophfroehlich commented 3 months ago

Sorry, my bad. I forgot that ament_python packages have the tests explicitly inside the test folder, like test/test_flake8.py and are tested even if no test_depend on ament_flake8 is given.