colcon / colcon.readthedocs.org

https://colcon.readthedocs.org
Creative Commons Attribution 4.0 International
10 stars 27 forks source link

Document colcon_defaults.yaml feature #89

Open jdlangs opened 2 years ago

jdlangs commented 2 years ago

Documentation for colcon/colcon-defaults#29

giuliano-97 commented 7 months ago

hi, I spent quite some time implementing good workarounds to achieve what this feature does just to find out after adventuring in the rabbit hole of github issues that this feature already exists - how about merging this so that the documentation is up to date and everyone can benefit from this? 😄

jdlangs commented 7 months ago

@giuliano-97 that's my bad for forgetting about this PR. It should be good to go. The failing readthedocs check looks like something new that probably should be resolved in another PR.

cottsay commented 7 months ago

I'm working on the failing deployment.

sdmcgrath commented 3 months ago

@jdlangs I think this should pass if you update past https://github.com/colcon/colcon.readthedocs.org/pull/99

jdlangs commented 3 months ago

@jdlangs I think this should pass if you update past #99

Thanks! Looking good now.