"X on next autoattack" Abilities

[Zarthbenn]

This is concerning abilities like Leona's Shield of Daybreak, Blitzcrank's Power fist and Garen's Decisive Strike (and similar).

The way these abilities work in league goes as follows:

-> Ability Cast -> Apply Appropriate Modifier for a duration + Disable Ability from being used or going on cooldown -> Autoattack hit OR Duration for modifier expires (a successful autoattack never happened) -> Remove modifier + Re-enable ability so it goes on cooldown.

The issue that I am having is creating a way to disable the ability for the duration of the modifier. During the modifier's lifespan the ability should not be able to cast or be on cooldown. A rough solution would be to extend the cooldown of the ability by the duration of the modifier (how swordzz did it for Garen) but its not very effective (can be abused by cdr and the such).

Ideally (although not really) there would be some sort of DisableAbility() function that we could run at creation of the modifier and reverse it at the end. To my knowledge there is not such a function.

Not really sure where to go from here. I might be missing some really simple solution or something else but I feel that this is a very specific ability behavior from league that should be implemented.

[gw1108]

Spirit Breaker's Charge of Darkness works in a similar way where they delay the cooldown until the ability is cancelled or is successful. Not sure how they did that though.

[Zarthbenn]

I forgot about that move! Unfortunately pizzalols spell library doesn't have it ported yet so we got to figure it out ourselves.

[wfzyx]

you probably need to add a hidden ability with the same kv descriptor but with the "toggle" behavior, like Leshrac's ult for e.g , then OnSpellStart of the real ability, you mark the ability as hidden, apply the modififer, and UnHidden the fake one with the "toogle behavior". You need to have a OnToogle on this ability to prevent activating/deactivating the ability for abuses, When modifier runs off, you set hidden on the fake one, unhidden the original an set cooldown manually.

[wfzyx]

Probably there is a way to make this with only the real spell, marking as toggle, preventing untoggle and set cooldown manually, but i'm not fully sure

[ChangedNameTo]

Have you guys seen the Spell Factory repository? You might be able to steal the code from there.

On Fri, Jul 31, 2015 at 2:09 PM Victor Hugo Panisa notifications@github.com wrote:

Probably there is a way to make with inly the real spell, marking as toggle, preventing untoggle and set cooldown manually, but i'm not fully sure

— Reply to this email directly or view it on GitHub https://github.com/coldAmphibian/Defense-of-the-Legends/issues/38#issuecomment-126773738 .

[wfzyx]

Giff Link @ChangedNameTo my google-fu skills failed on finding this

[gw1108]

He might be talking about this : https://github.com/Pizzalol/SpellLibrary

[wfzyx]

This is exactly what we are talking earlier ._.

[coldAmphibian]

what about how old tusks's walrus punch worked?

[ChangedNameTo]

Well I'm retarded.

On Sat, Aug 1, 2015 at 9:36 PM Cold Amphibian notifications@github.com wrote:

what about how old tusks's walrus punch worked?

— Reply to this email directly or view it on GitHub https://github.com/coldAmphibian/Defense-of-the-Legends/issues/38#issuecomment-126972245 .

[wfzyx]

Archived