search

coldAmphibian / Defense-of-the-Legends

30 stars 11 forks source link

Overlapping Overrides #4

Closed ChangedNameTo closed 9 years ago

ChangedNameTo commented 9 years ago

While not an issue right now, we need to keep track of which champ we are overriding so we don't end up with compiler conflicts where 2 champs override the same champion, ie having two champions with an "override_hero" "npc_dota_hero_alchemist" tag

wfzyx commented 9 years ago

This isn't top level issue, because you just need to change 1 line, and nothing else really conflicts.

If happens we chose one to change, no worry about

Capruce commented 9 years ago

Might I suggest an additional column on the wiki page where people say what hero they're working on. Write down which hero you're overriding. Simple.

Capruce commented 9 years ago

Here. https://github.com/coldAmphibian/DotL-Hammer-Old/wiki/Hero-Overriding

ChangedNameTo commented 9 years ago

Good thinking, I'm gonna close this