Closed SMSMichael closed 1 year ago
Hi @SMSMichael, I've been super busy but I'm finally getting a chance to look at this. I'm guessing you didn't any further with the remaining issue. Unless you have any more code to add here, I'll probably merge this and continue working on it.
@SMSMichael I pulled your changes and good news-- they are 100% passing on both Lucee 5.3.10 and Adobe CF 2023. You never said what CF engine/version you were getting the errors on, but perhaps it was a CF engine bug?
Description
This PR is an attempt to create a minimum viable product (MVP) update that updates the underlying LaunchDarkly Java SDK to the latest version 6 (6.0.6) (see #3). As an MVP update, I am not attempting to introduce support for the new Context targeting system introduced by v6, but instead attempting to get current implementations based on the v5 working in v6.
Changes Introduced
I introduced the following changes:
test-flags.json
file to include a "string-feature-with-targeting" example that includes a populatedtargets
attribute, as well as includes the newcontextTargets
attribute (purpose: testing new v6 syntax changes)LDTest.cfc
to validate that flag targeting was still working as expected ("can correctly target a flag variation based on the user") (purpose: testing new v6 syntax changes)describe()
blocks, or any existing expectations around testing style guides. Please feel free to revert this change to return to the format the tests were originally in.Issues Resolved & Remaining
When the SDK version was swapped out in this branch, I encountered 3 failing unit tests:
secondary
attribute no longer being a supported default user attribute. I have applied the change in this branch to treat this as a custom attribute, which seems to have resolved the issueand
Hoping someone else with a deeper understanding of the underlying Java proxy system can spot the issue.