coldbox-modules / LaunchDarklySDK

A CFML SDK for Launch Darkly feature flags
8 stars 4 forks source link

Adding support for SDK privateAttributes feature (protects PII but still be able to use it for targeting) #6

Closed SMSMichael closed 1 year ago

SMSMichael commented 1 year ago

This PR introduces 2 changes into the code base:

A note about handling private attributes in LaunchDarkly: LD supports the ability to define context properties/attributes as "private" this means that these attributes may be used for targeting purposes but will not be sent to LaunchDarkly as part of it's SDK telemetry and analytics data. This is meant to allow us to use context attributes that include PII (like email) without having it reside in LaunchDarkly's context database. To mark an attribute the Java SDK provides a context builder property called privateAttributes that includes an array of property names to be treated as private (see https://docs.launchdarkly.com/sdk/features/private-attributes for more info)

bdw429s commented 1 year ago

@SMSMichael Sorry for the delay on this. I'm finally back from traveling and CFSummit and had a chance to review. Everything looks good so I have merged!

bdw429s commented 1 year ago

I have published as version 2.1.0. Please help confirm.